Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: p-table #14164

Closed
MaewenPell opened this issue Nov 21, 2023 · 0 comments · Fixed by #14165
Closed

Component: p-table #14164

MaewenPell opened this issue Nov 21, 2023 · 0 comments · Fixed by #14165
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.9.0

Comments

@MaewenPell
Copy link

MaewenPell commented Nov 21, 2023 •
edited
Loading

Describe the bug

The [showInitialSortBadge] attribute from p-table should disable the badges if we set it to false.

getMultiSortMetaIndex

Environment

Angular 16.2.8 / primeng 16.8.0

Reproducer

https://stackblitz.com/edit/ace6ra?file=src%2Fapp%2Fdemo%2Ftable-lazy-load-demo.html

Angular version

16.2.9

PrimeNG version

16.8.0

Build / Runtime

Angular CLI App

Language

ES6

Node version (for AoT issues node --version)

18.12.1

Browser(s)

No response

Steps to reproduce the behavior

https://stackblitz.com/edit/ace6ra?file=src%2Fapp%2Fdemo%2Ftable-lazy-load-demo.html,src%2Fapp%2Fdemo%2Ftable-lazy-load-demo.ts

Expected behavior

I create a p-table component with a [sortMode]='multiple' and [multiSortMeta]="multiple" and [showInitialSortBadge]="false" I should no have the p-sortable-column-badge displayed but they are (cf stackblitz

PR

#14165
@MaewenPell MaewenPell added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 21, 2023
@MaewenPell MaewenPell mentioned this issue Nov 21, 2023
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 22, 2023
@cetincakiroglu cetincakiroglu added this to the 16.9.0 milestone Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.9.0
Development

Successfully merging a pull request may close this issue.

Fix conditional logic in SortIcon component MaewenPell/primeng
2 participants
@MaewenPell @cetincakiroglu