Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Tree checkbox disabled css not working #14251

Closed
yelhouti opened this issue Nov 30, 2023 · 0 comments · Fixed by #14441
Closed

Component: Tree checkbox disabled css not working #14251

yelhouti opened this issue Nov 30, 2023 · 0 comments · Fixed by #14441
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.3.1

Comments

@yelhouti
Copy link
Contributor

Describe the bug

https://github.com/primefaces/primeng/blob/d6ce9fcf6ead4fb4e2c80d3d3e3de3cc3fb14022/src/app/components/tree/tree.ts#L107C37-L107C51

The p-checkbox-box should have p-disable when disabled

Environment

Angular app with primeng installed

Reproducer

No response

Angular version

17.0.0

PrimeNG version

17.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.1

Browser(s)

No response

Steps to reproduce the behavior

  • create a tree with a disabled node (either selected or not)
  • Notice there is no visual difference compared to non disabled nodes

Expected behavior

Disabled options should be visible as disabled
@yelhouti yelhouti added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 30, 2023
@Alhajras Alhajras mentioned this issue Dec 27, 2023
Merged
1 task
@cetincakiroglu cetincakiroglu added this to the 17.3.1 milestone Jan 4, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.3.1
Development

Successfully merging a pull request may close this issue.

Fix the tree checkbox css issue and make it clearer when it is disabled Alhajras/primeng
2 participants
@yelhouti @cetincakiroglu