Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping Functionality in p-table Breaks After Pagination Navigation Beyond First Page #15192

Closed
EleftheriosTsiridis opened this issue Mar 28, 2024 · 8 comments · Fixed by #16307
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working v18-port
Milestone

Comments

@EleftheriosTsiridis
Copy link

Describe the bug

Issue Title:

Grouping Functionality in p-table Breaks After Pagination Navigation Beyond First Page

Issue Description:

When integrating paginator logic into the existing PrimeNG component, a functionality inconsistency occurs. After navigating beyond the first page using the paginator controls, the grouping functionality ceases to operate correctly. Instead of maintaining the intended grouping structure, each row appears to be grouped individually.

Steps to Reproduce:

Use the existing PrimeNG example of Row Group Subheader in StackBlitz (accessible via https://primeng.org/table).
Integrate paginator logic into the PrimeNG <p-table> component.
Navigate beyond the first page using the paginator controls.
Observe the breakdown in grouping functionality, where each row seems to be grouped individually.

Expected Behavior:

After navigating to subsequent pages using the paginator, the grouping functionality should remain intact, preserving the original group structure as defined by the groupRowsBy attribute.

Additional Information:

PrimeNG Version: 17.12.0
Angular Version: 17.3.1

Note:

This issue significantly impacts user experience and functionality, especially when managing large datasets where pagination and grouping are vital features. Prompt attention and resolution of this matter would be greatly appreciated. Additionally, it's worth noting that this issue may be related to #14672.

Environment

stackblitz.com

Reproducer

No response

Angular version

17.3.1

PrimeNG version

17.12.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v18.18.0

Browser(s)

No response

Steps to reproduce the behavior

  1. Use the existing PrimeNG example of Row Group Subheader in StackBlitz (accessible via https://primeng.org/table).
  2. Integrate paginator logic into the PrimeNG component.
  3. Navigate beyond the first page using the paginator controls.
  4. Observe the breakdown in grouping functionality, where each row seems to be grouped individually.

Expected behavior

No response

@EleftheriosTsiridis EleftheriosTsiridis added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 28, 2024
@psarno
Copy link

psarno commented Apr 4, 2024

This seems like the issue I opened back in 2022 (11764).

It's still open (and still broken) last I checked.

@EleftheriosTsiridis
Copy link
Author

This seems like the issue I opened back in 2022 (11764).

It's still open (and still broken) last I checked.

Hello,

I wanted to update you on the issue. The grouping functionality was working between versions 17.2 to 17.11 but seems to have regressed in the latest version.

Can you reproduce the problem in StackBlitz for those versions? Share the links so we can investigate.

Best regards

@DSyarovIV
Copy link

Hello,
I managed to reproduce it. Here is a stackblitz: https://stackblitz.com/edit/3gpdab?file=src%2Fapp%2Fdemo%2Ftable-subheader-grouping-demo.html

@EleftheriosTsiridis
Copy link
Author

Hello, I managed to reproduce it. Here is a stackblitz: https://stackblitz.com/edit/3gpdab?file=src%2Fapp%2Fdemo%2Ftable-subheader-grouping-demo.html

Yes, as i told you after navigating beyond the first page using the paginator controls, the grouping functionality ceases to operate correctly. Instead of maintaining the intended grouping structure, each row appears to be grouped individually.

Any help would be appreciated.

Here are some screenshots from your stackblitz link:
Screenshot_1
Screenshot_2
Screenshot_3

@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 20, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 17.17.1 milestone May 20, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 17.18.0, 18.Future May 30, 2024
@marshal-yurii
Copy link

This seems like the issue I opened back in 2022 (11764).
It's still open (and still broken) last I checked.

Hello,

I wanted to update you on the issue. The grouping functionality was working between versions 17.2 to 17.11 but seems to have regressed in the latest version.

Can you reproduce the problem in StackBlitz for those versions? Share the links so we can investigate.

Best regards

Thank you, e.g. v ~17.9.0 works for groups through pagination

@digeomel
Copy link

I can confirm that it seems to be fixed in v ~17.9.0, but it is broken again on later versions that I tried 🤷🏻‍♂️

@AyoubTachtouktDekra
Copy link

Still got this error

@Rodesc
Copy link

Rodesc commented Aug 23, 2024

I still have this error in 17.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working v18-port
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants