Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: Reorderable column false still gives cursor move #15656

Closed
Emiliorth opened this issue May 22, 2024 · 2 comments · Fixed by #15667
Closed

Table: Reorderable column false still gives cursor move #15656

Emiliorth opened this issue May 22, 2024 · 2 comments · Fixed by #15667
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Emiliorth
Copy link

Describe the bug

Table: Reorderable column false and pReorderableColumnDisabled true still gives cursor move

Environment

Windows 10 PrimeNG 17.17.0 Angular 17

Reproducer

No response

Angular version

17.3.0

PrimeNG version

17.17.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

21.6.0

Browser(s)

Chrome

Steps to reproduce the behavior

No response

Expected behavior

No response

@Emiliorth Emiliorth added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 22, 2024
@RogueTea
Copy link
Contributor

Hello, I'm wondering if you're still using pReorderableColumn in your code like:

  <p-table [value]="products" [columns]="cols" [reorderableColumns]="false" [tableStyle]="{ 'min-width': '50rem' }">
                    <ng-template pTemplate="header" let-columns>
                        <tr>
                            <th style="width:3rem"></th>
                            <th *ngFor="let col of columns" pReorderableColumn>
                                {{ col.header }}
                            </th>
                        </tr>
                    </ng-template>
                    <ng-template pTemplate="body" let-rowData let-columns="columns" let-index="rowIndex">
                        <tr [pReorderableRow]="index" [pReorderableRowDisabled]="true">
                            <td>
                                <span class="pi pi-bars" pReorderableRowHandle></span>
                            </td>
                            <td *ngFor="let col of columns">
                                {{ rowData[col.field] }}
                            </td>
                        </tr>
                    </ng-template>
                </p-table>

@Emiliorth
Copy link
Author

Emiliorth commented May 23, 2024

Yes, I do use [reorderableColumns] binding on p-table and this is my th:
<th [pReorderableColumnDisabled]="someReordCondition" [pSortableColumn]="sortField" [pSortableColumnDisabled]="someSortCondition" pReorderableColumn [id]="id"> ... </th>
I am looping over my @input() columns instead of using let-columns
I do not use row reordering

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 30, 2024
@cetincakiroglu cetincakiroglu added this to the 17.18.0 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants