Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table select all checkbox deselect disabled selected checkboxes #15780

Open
VolodymyrKornetskyi opened this issue Jun 3, 2024 · 4 comments
Open
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@VolodymyrKornetskyi
Copy link

Describe the bug

Select/Unselect all checkbox should not affect disabled checkboxes (making them unselected now)

Connected to #15338

Environment

Google Chrome. MacOS

Reproducer

https://stackblitz.com/edit/e6puho?file=src%2Fapp%2Ftable-checkbox-selection-demo.html

Angular version

17

PrimeNG version

17.18

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.13

Browser(s)

Chrome 125.0

Steps to reproduce the behavior

  1. Open repro project
  2. Click Select all in header

Expected behavior

All checkboxes become to be selected and on "unselect all" click all not disabled checkboxes become to be unselect.
Expected behavior - don't change the state of disabled checkboxes

@VolodymyrKornetskyi VolodymyrKornetskyi added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 3, 2024
@VolodymyrKornetskyi
Copy link
Author

Guys any updates?

@MaksymPlotnikov
Copy link

same here! +1

@roman-bychkov
Copy link

+1

@mehmetcetin01140 mehmetcetin01140 added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 26, 2024
@mehmetcetin01140 mehmetcetin01140 added this to the 18.Future milestone Jun 26, 2024
@MaurizioCasciano
Copy link

MaurizioCasciano commented Oct 24, 2024

Same here with 17.18.11

Disabled row checkboxes shouldn't be changed/unselected by the Table unselect all checkbox.
The same thing (disabled checbox unselection) when checking/unchecking another row checkbox (not disabled).

The issue was introduced in https://github.com/primefaces/primeng/releases/tag/17.17.0 in an attempt to fix the issue #15338 via the PR #15591

image

Due to this change a row checkbox can either be checked (selected) or disabled, but not both at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

5 participants