Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabView: Demo code for TabViewDynamic is wrong #16148

Closed
daniela-bonvini opened this issue Aug 1, 2024 · 1 comment · Fixed by #16150
Closed

TabView: Demo code for TabViewDynamic is wrong #16148

daniela-bonvini opened this issue Aug 1, 2024 · 1 comment · Fixed by #16150
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@daniela-bonvini
Copy link

Describe the bug

In the TabViewDynamic section inside PrimeNG documentation, the code example is wrong and the correlated stackblitz does not work for a couple of typos and wrong imports

Environment

Linux

Reproducer

https://stackblitz.com/edit/dqnxeb?file=src%2Fmain.ts

Angular version

18.0.1

PrimeNG version

17.18.6

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.3

Browser(s)

No response

Steps to reproduce the behavior

Got to https://primeng.org/tabview#dynamic, check the TS code or click on the Stackblitz button

Expected behavior

THe demo should be correct and working in the Stackblitz

@daniela-bonvini daniela-bonvini added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 1, 2024
@daniela-bonvini
Copy link
Author

daniela-bonvini commented Aug 1, 2024

I don't know how to modify the demo directly, but here is a working Stackblitz forked from the original broken one which I fixed, if you want to use it:
https://stackblitz.com/edit/tabviewdynamic?file=src%2Fapp%2Ftab-view-dynamic-demo.ts

@cetincakiroglu cetincakiroglu added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 1, 2024
@cetincakiroglu cetincakiroglu added this to the 17.18.7 milestone Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants