Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileUploadComponent : maxFileSize appears to be calculated in as decimal vs binary #16696

Open
TheTiGuR opened this issue Nov 5, 2024 · 0 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@TheTiGuR
Copy link

TheTiGuR commented Nov 5, 2024

Describe the bug

Minor issue, but confusing when setting the maxFileSize attribute to "30_000_000" for 30MB, we get an error with a 30MB file that says that the max upload size is 28.839MB. Looking into it, this is the binary notation of 30_000_000 instead of the maybe more commonly expected decimal. This should be noted on the docs to prevent confusion.

Environment

n/a

Reproducer

No response

Angular version

17

PrimeNG version

17

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

30_000_000 should be less ambiguous as to what most(?) users would normally see on their computers as to the size of a file.

@TheTiGuR TheTiGuR added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant