Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong documentation for controlCase on TabView #9490

Closed
macelai opened this issue Nov 4, 2020 · 0 comments
Closed

Wrong documentation for controlCase on TabView #9490

macelai opened this issue Nov 4, 2020 · 0 comments
Assignees
@yigitfindikli
Labels
LTS-FIXED-9.2.2 Fixed in PrimeNG LTS 9.2.2 LTS-FIXED-10.0.7 Fixed in PrimeNG LTS 10.0.7 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
11.2.0

Comments

@macelai
Copy link

macelai commented Nov 4, 2020 •
edited
Loading 

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior

The documentation for controlCase is wrong. controlCase property is for TabView, not TabPanel.
https://www.primefaces.org/primeng/v9.1.7-lts/#/tabview

primeng/src/app/components/tabview/tabview.ts

Line 157 in dcb96fd

@Input() controlClose: boolean;

Expected behavior

Documentation should show this property for TabViewl

Angular version: 9.X

PrimeNG version: 9.X
@yigitfindikli yigitfindikli added LTS-FIXED-9.2.0 Fixed in PrimeNG LTS 9.2.0 LTS-PORTABLE and removed LTS-FIXED-9.2.0 Fixed in PrimeNG LTS 9.2.0 labels Nov 25, 2020
@yigitfindikli yigitfindikli self-assigned this Jan 12, 2021
@yigitfindikli yigitfindikli added this to the 11.2.0 milestone Jan 12, 2021
@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jan 12, 2021
@yigitfindikli yigitfindikli added LTS-FIXED-10.0.7 Fixed in PrimeNG LTS 10.0.7 LTS-FIXED-9.2.2 Fixed in PrimeNG LTS 9.2.2 and removed LTS-PORTABLE labels Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
LTS-FIXED-9.2.2 Fixed in PrimeNG LTS 9.2.2 LTS-FIXED-10.0.7 Fixed in PrimeNG LTS 10.0.7 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
11.2.0
Development

No branches or pull requests
2 participants
@macelai @yigitfindikli