Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the user choose where to place a DynamicDialog rather than in body #9546

Closed
john8329 opened this issue Nov 19, 2020 · 4 comments · Fixed by #12283
Closed

Let the user choose where to place a DynamicDialog rather than in body #9546

john8329 opened this issue Nov 19, 2020 · 4 comments · Fixed by #12283
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@john8329
Copy link

john8329 commented Nov 19, 2020

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[x] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
When creating a DynamicDialog, PrimeNG creates an element as a direct child of the element. This is non-configurable.

Expected behavior
It'd be nice to have a parameter like appendTo to specify which element to attach the dialog to. I need to wrap every element created in a <div> but right now it's not possible.

What is the motivation / use case for changing the behavior?
The aim is to block the entire UI with a graphic filter when the app is in the "reconnecting" state. The filter can be applied to a divider that contains the entire UI.

  • Angular version: 9

  • PrimeNG version: 9.1.3

@yigitfindikli yigitfindikli added the Type: New Feature Issue contains a new feature or new component request label Nov 25, 2020
@ferikeem
Copy link

ferikeem commented Apr 5, 2022

I would also like this feature. I implemented a global context-menu (for translating labels and stuff), and it doesn't work on dynamicdialog. Now there are possible solutions to this, but it would be much cleaner to append the dynamicdialog to a top-level div (or something). The contextmenu does work in the (plain) dialog component.

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

@john8329
Copy link
Author

The issue is still relevant, although as a workaround I'm closing all dialogs when the app displays the "reconnecting" overlay.

@mertsincan mertsincan reopened this Nov 13, 2022
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 13, 2022
@shayl29
Copy link
Contributor

shayl29 commented Nov 24, 2022

@mertsincan I have created a PR for this request
#12283

@mertsincan mertsincan linked a pull request Aug 21, 2023 that will close this issue
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 21, 2023
@mertsincan mertsincan removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants