Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Match All vs Match Any not working twice #9836

Closed
hioymaci opened this issue Jan 29, 2021 · 0 comments
Closed

Filter Match All vs Match Any not working twice #9836

hioymaci opened this issue Jan 29, 2021 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@hioymaci
Copy link

[x] bug report

Plunkr Case (Bug Reports)
Demo is here: https://www.primefaces.org/primeng/showcase/#/table/filter
You can try it with sample table in official demo page.

Current behavior

Match Any filter is not saved in numeric filtering columns.
Expected behavior

Match Any should be saved.
Minimal reproduction of the problem with instructions

  1. Add these two filter to column Balance in sample table:
    1.1 Match All
    1.2 Greater than equal to 50,000$
    1.3 Less than equal to 60,000$

There are 200 entries in the table before filter. After filter 16 entries exist.
If you changed Match All to Match Any, there are 200 entries. No problem, it is correct because all values either greater than 50k or less than 60k.
But if you click again the filter, in the first dropdown menu Match All selected is shown. But we selected Match Any. In addition if I changed that dropdown, filter doesn't run. You should reload the page to filter again that column.

What is the motivation / use case for changing the behavior?

Please tell us about your environment:
Version 88.0.4324.104 (Official Build) (64-bit) at Windows 10.

  • Angular version: 11

  • PrimeNG version: 11.2.0

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Version 88.0.4324.104 (Official Build) (64-bit)
Firefox 84.0.1 (64-bit) at windows 10

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Feb 15, 2021
@yigitfindikli yigitfindikli added this to the 11.2.2 milestone Feb 15, 2021
@yigitfindikli yigitfindikli self-assigned this Feb 15, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants