Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-cascadeSelect optionGroupChildren wrong type definition #9952

Closed
fabien-ml opened this issue Feb 28, 2021 · 3 comments
Closed

p-cascadeSelect optionGroupChildren wrong type definition #9952

fabien-ml opened this issue Feb 28, 2021 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@fabien-ml
Copy link

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting

Current behavior
When using p-cascadeSelect [optionGroupChildren]="['states', 'cities']" (like in the doc), the typescript compiler says "Type 'string[]' is not assignable to type 'string'".

Setting the type manually to string[] in the .d.ts file of primeng fix it.

Expected behavior
Should no cause error.

Minimal reproduction of the problem with instructions

  • Create a new angular project en vscode
  • Add primeng
  • Folow primeng cascade select doc example

Please tell us about your environment:

  • Mac OS
  • VS Code
  • NPM
  • Angular version: 11.2.3

  • PrimeNG version: 11.2.3

@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 1, 2021
@yigitfindikli yigitfindikli self-assigned this Mar 1, 2021
@yigitfindikli yigitfindikli removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 1, 2021
@yigitfindikli yigitfindikli removed their assignment Mar 1, 2021
@yigitfindikli
Copy link
Contributor

Hi @fabien-ml,

I couldn't replicate it with v11.2.3 can you share a sample project or stackblitz example?

@fabien-ml
Copy link
Author

Hi, here is a sample project and screenshot from my ide.
Capture d’écran 2021-03-01 à 08 49 36

primeng-sandbox.zip

@yigitfindikli
Copy link
Contributor

Thanks for your report and effort. I'll add this issue to our roadmap.

@yigitfindikli yigitfindikli added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Mar 1, 2021
@yigitfindikli yigitfindikli self-assigned this Mar 1, 2021
@yigitfindikli yigitfindikli added this to the 11.3.0-rc.1 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants