Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard support to DataTable with Checkbox selection #1005

Closed
kambo opened this issue Aug 30, 2019 · 1 comment
Closed

Add keyboard support to DataTable with Checkbox selection #1005

kambo opened this issue Aug 30, 2019 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@kambo
Copy link

kambo commented Aug 30, 2019

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior

Checkboxes in DataTable is not accessible by keyboard

Expected behavior

"Tabbing" between the checkboxes in the DataTable should be highlighted. Selecting an row should be possible with "Enter" key or "Space"

Minimal reproduction of the problem with instructions

Try tabbing between checkboxes in DataTable on your demo page: https://www.primefaces.org/primereact/#/datatable/selection

Please tell us about your environment:

  • React version:
  • PrimeReact version:

Your demo page: https://www.primefaces.org/primereact/#/datatable/selection

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]
@mertsincan mertsincan self-assigned this Sep 9, 2019
@mertsincan mertsincan changed the title Checkboxes in DataTable is not accessible by keyboard Add keyboard support to DataTable with Checkbox selection Sep 9, 2019
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Sep 9, 2019
@mertsincan mertsincan added this to the 3.2.0 milestone Sep 9, 2019
@mertsincan
Copy link
Member

Thanks a lot for the PR! But, we'd better use Checkbox component in RowCheckbox.

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants