Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Selection Using Shift Key for TreeTable #1120

Closed
pholeth opened this issue Dec 10, 2019 · 7 comments
Closed

Multiple Selection Using Shift Key for TreeTable #1120

pholeth opened this issue Dec 10, 2019 · 7 comments
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@pholeth
Copy link
Contributor

pholeth commented Dec 10, 2019

I'm submitting a ... (check one with "x")

[ ] bug report
[X] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
Multiple Selection using Shift key has been supported in DataTable since version 3.1.8, but not in TreeTable. It should be nice to have similar support for TreeTable. Reference issue #934

Expected behavior
Multiple Selection using Shift key is supported for TreeTable

  • PrimeReact version:
    3.3.4

  • Browser: [all ]

  • Language: [all]

@venilillkall
Copy link

Yes, please

@mertsincan mertsincan added the Type: New Feature Issue contains a new feature or new component request label Jan 17, 2020
@m-vignesh
Copy link

Is this feature available in the latest version 4.2.2?
https://www.primefaces.org/primereact/showcase/#/treetable/selection ==> MetaKeySelection shows the solution for this but not working when applied.

@pholeth
Copy link
Contributor Author

pholeth commented Jul 9, 2020

No, this request refers to the feature that users can do range selection with the Shift Key. The current support with MetaKeySelection only allows to select multiple but by clicking one by one.

@pholeth
Copy link
Contributor Author

pholeth commented Jul 10, 2020

Hi, I made a support for this in my local branch, but cannot push to the origin due to permission. Could you please send me document on how to contribute the patch to the project? Thanks.

@jjunt
Copy link

jjunt commented Nov 24, 2020

@mertsincan : Could you please advise how @pholeth can submit the feature implementation for review? This would be a really nice feature addition. Thanks for any advise you could provide!

@mertsincan mertsincan self-assigned this Feb 9, 2021
@mertsincan mertsincan added this to the 6.1.0 milestone Feb 9, 2021
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Feb 9, 2021
@mertsincan mertsincan modified the milestones: 6.1.0, 7.0.0 Mar 9, 2021
@jjunt
Copy link

jjunt commented Mar 19, 2021

this feature has been implemented in the pull request: #1728

Any chance we can get this migrated? this is highly wished feature

@hernyo
Copy link

hernyo commented Mar 22, 2021

+1, waiting for this feature as well.

@mertsincan mertsincan removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jul 6, 2021
@mertsincan mertsincan modified the milestones: 8.0.0, 7.0.0.Final Nov 3, 2021
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: New Feature Issue contains a new feature or new component request labels Nov 3, 2021
@mertsincan mertsincan removed their assignment Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

6 participants