Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type definition for onChange of form components #1199

Closed
dattebayorob opened this issue Feb 18, 2020 · 1 comment
Closed

Improve type definition for onChange of form components #1199

dattebayorob opened this issue Feb 18, 2020 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@dattebayorob
Copy link

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[ ] bug report
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
Please fork the codesandbox below and create a case demonstrating your bug report. Issues without a codesandbox have much less possibility to be reviewed.

https://codesandbox.io/s/qjx332qq4

Current behavior

The type definition of Dropdown omits the target object sent with onChange event.

Expected behavior

Dunno if it's purposeful, but for typescript users the target seens more natural ( event.target )

Minimal reproduction of the problem with instructions

Please tell us about your environment:

  • React version:
  • PrimeReact version:
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
  • Language: [all | TypeScript X.X | ES6/7 | ES5]
@cagataycivici
Copy link
Member

target is there for form libraries like formik.

@cagataycivici cagataycivici self-assigned this Mar 12, 2020
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 12, 2020
@cagataycivici cagataycivici added this to the 4.1.1 milestone Mar 12, 2020
@cagataycivici cagataycivici changed the title Add target on type definition of Dropdown ( onChange event ) Improve type definition for onChange of form components Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants