Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on TreeTable docs about responsive #1253

Closed
Mike-U5 opened this issue Mar 11, 2020 · 2 comments
Closed

Error on TreeTable docs about responsive #1253

Mike-U5 opened this issue Mar 11, 2020 · 2 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@Mike-U5
Copy link

Mike-U5 commented Mar 11, 2020

I'm submitting a ... (check one with "x")
[x] bug report
[ ] feature request
[ ] support request

Codesandbox Case
https://codesandbox.io/s/primereact-test-nbme8?fontsize=14&hidenavigation=1&theme=dark

Behavior
The documentation seems to imply that a TreeTable has a responsive mode which can be enabled by setting the "responsive" prop to true. However, no such prop appears to exist.

Looking at the Treetable.d.ts on git seems to imply that such a prop has never existed.
https://github.com/primefaces/primereact/blob/master/src/components/treetable/TreeTable.d.ts

This occurs in 3.4.0 and 4.2.0.

  • Language: TypeScript
@cagataycivici
Copy link
Member

Please see;

#1250

We've decided not to make it built-in as it restricts the flexibility, instead we'll provide demos.

Until it is deprecated in 4.2.0, I'll fix this issue for 4.1.1

https://www.primefaces.org/primereact/showcase/#/treetable/responsive

@cagataycivici cagataycivici self-assigned this Mar 12, 2020
@cagataycivici cagataycivici added the Type: Bug Issue contains a defect related to a specific component. label Mar 12, 2020
@cagataycivici cagataycivici added this to the 4.1.1 milestone Mar 12, 2020
@cagataycivici cagataycivici changed the title Responsive prop does not exist on TreeTable Fixed TreeTable docs about responsive Mar 12, 2020
@cagataycivici
Copy link
Member

Just realized that, it is due to a doc error, there is no need for a responsive prop in TreeTable. Please apply the demo solution in comment above.

@cagataycivici cagataycivici changed the title Fixed TreeTable docs about responsive Error on TreeTable docs about responsive Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants