Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling a Menu Item doesnt add aria-disabled label #1434

Closed
nuur94 opened this issue Jul 7, 2020 · 0 comments
Closed

Disabling a Menu Item doesnt add aria-disabled label #1434

nuur94 opened this issue Jul 7, 2020 · 0 comments
Assignees
@mertsincan
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
6.1.0

Comments

@nuur94
Copy link

nuur94 commented Jul 7, 2020

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request

Current behavior
MenuItem with disabled property doesn't add the appropriate aria-labels

Expected behavior
MenuItem with disabled property should add 'aria-disabled="true"' to the underlying "li" element.

  • React version:
    16.12.0

  • PrimeReact version:
    3.4.0

  • Browser: [all]
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Feb 10, 2021
@mertsincan mertsincan self-assigned this Feb 10, 2021
@mertsincan mertsincan added this to the 6.1.0 milestone Feb 10, 2021
@dependabot dependabot bot mentioned this issue Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
6.1.0
Development

No branches or pull requests
2 participants
@mertsincan @nuur94