Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OverlayPanel: appendTo="body" throws exception #206

Closed
RushPVA opened this issue Dec 4, 2017 · 3 comments
Closed

OverlayPanel: appendTo="body" throws exception #206

RushPVA opened this issue Dec 4, 2017 · 3 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@RushPVA
Copy link

RushPVA commented Dec 4, 2017

TypeError: Argument 1 of Node.appendChild is not an object.
<OverlayPanel className="ui-g-8" ref={el => this.fieldPicker = el} showCloseIcon={true} dismissable={true} appendTo="body">

http://prntscr.com/his990

@cagataycivici cagataycivici self-assigned this Dec 4, 2017
@cagataycivici
Copy link
Member

Better to use portals here, I'll check this now.

@cagataycivici cagataycivici added the Type: Bug Issue contains a defect related to a specific component. label Dec 4, 2017
@cagataycivici cagataycivici added this to the 1.3.0 milestone Dec 4, 2017
@cagataycivici
Copy link
Member

cagataycivici commented Dec 4, 2017

Fixed by using portals, we're migrating all appendTos to portals and works great. With 1.3.0, usage should be;

<OverlayPanel appendTo={document.body}></OverlayPanel>

@lharley
Copy link

lharley commented Nov 8, 2018

appendTo={document.body} -- Can't thank you enough for this answer. Worked perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

3 participants