Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageParams TypeScript interface improvement on DataTable, TreeTable and DataView #2070

Closed
hstevanoski opened this issue May 28, 2021 · 0 comments
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@hstevanoski
Copy link

I'm submitting a ...

[ ] bug report
[X] feature request
[ ] support request

Current behavior
The DataTablePageParams interface used in the DataTable's handlePaginationChange method is currently defined as:

interface DataTablePageParams {
    first: number;
    rows: number;
}

but it's missing the page and pageCount properties.

Screenshot of the actual event object when logged in the console:

Expected behavior
The interface should include the aforementioned properties as well.

@mertsincan mertsincan changed the title DataTablePageParams TypeScript interface improvement PageParams TypeScript interface improvement on DataTable, TreeTable and DataView Jun 10, 2021
@mertsincan mertsincan self-assigned this Jun 10, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Jun 10, 2021
@mertsincan mertsincan added this to the 6.4.0 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants