Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: Respect custom column definition #2268

Closed
ShashankSuresh opened this issue Sep 1, 2021 · 3 comments
Closed

DataTable: Respect custom column definition #2268

ShashankSuresh opened this issue Sep 1, 2021 · 3 comments
Assignees
Labels
Resolution: Wontfix Issue will not be fixed due to technical limitations

Comments

@ShashankSuresh
Copy link

ShashankSuresh commented Sep 1, 2021

Current behavior
I am creating a custom Column for Data Table and using Styled System display properties to it. But it does not respect it.

Am I doing something wrong ?
Does Column not support Styled System ?
Does Column only support inline styles and css classes ?

Expected behavior
Column component should respect Styled System.

Minimal reproduction of the problem with instructions
Open the models, then click the dropdown.

Please tell us about your environment:
VSCode

React version:
17.0.2

PrimeReact version:
^6.5.0

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
Chrome 92.0.4515.159

ColumnStyledSystem
CustomColumn

@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 4, 2021
@mertsincan mertsincan self-assigned this Nov 4, 2021
@melloware melloware changed the title Data Table Column | Not Supporting System System Data Table Column | Not Supporting Styled System Apr 16, 2022
@melloware melloware changed the title Data Table Column | Not Supporting Styled System DataTable: Respect custom column definition Apr 23, 2022
@melloware
Copy link
Member

I ran into this myself. I would like to be able to define a custom column that extends the Datatable Column object

@jorrit-hdrn
Copy link

I have the same issue!

@melloware
Copy link
Member

Similar to this answer I don't think this will be implemented because Columns are not components that render themselves: #2052 (comment)

@melloware melloware closed this as not planned Won't fix, can't repro, duplicate, stale Nov 18, 2022
@melloware melloware added Resolution: Wontfix Issue will not be fixed due to technical limitations and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Wontfix Issue will not be fixed due to technical limitations
Projects
None yet
Development

No branches or pull requests

4 participants