Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog typescript error #2747

Closed
jewe11er opened this issue Apr 12, 2022 · 1 comment
Closed

Dialog typescript error #2747

jewe11er opened this issue Apr 12, 2022 · 1 comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@jewe11er
Copy link

jewe11er commented Apr 12, 2022

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Code

<Dialog
        onHide={() => setShowMessage(false)}
        visible={showMessage}
        footer={dialogFooter}
        showHeader={false}
        breakpoints={{ '960px': '60vw', '640px': '90vw' }}
        style={{ width: '30vw' }}
>
        <div>Content</div>
</Dialog>

Current behavior
Got a error:
Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Dialog> & Readonly<DialogProps>'.

Expected behavior
No TS errors

Please tell us about your environment:
IDE Webstorm 2022.1

React version:
React 18.0.0

Typescript version:
Typescript 4.6.3

PrimeReact version:
PrimeReact 8

@melloware
Copy link
Member

It's due to React 18. It's fixed by #2732

@melloware melloware added the Type: Bug Issue contains a defect related to a specific component. label Apr 12, 2022
@melloware melloware added this to the 8.0.0-rc.2 milestone Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

No branches or pull requests

2 participants