Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dialog positioning with Dynamic content #320

Closed
YourJest opened this issue Feb 19, 2018 · 1 comment
Closed

Improve dialog positioning with Dynamic content #320

YourJest opened this issue Feb 19, 2018 · 1 comment
Assignees
@cagataycivici
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
1.5.0

Comments

@YourJest
Copy link

I'm submitting a ...

[X] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=57

Plunkr Case (Bug Reports)

https://plnkr.co/edit/w8lMyBmyyzqZodgn7dZl?p=preview

Current behavior

When DataTable fills for the first time in Dialog window, Dialog does not re-render and Dialog does not scrollable
Expected behavior

Dialog correctly adds a scrollbar if size is fixed, or it dynamically resizes when data become bigger than the Dialog size
Minimal reproduction of the problem with instructions

Please tell us about your environment:

  • React version:
    React 16.2.0

  • PrimeReact version:
    PrimeReact 1.4.1

  • Browser: [ Firefox, Chromium ]

  • Language: [ES 6/7]
@cagataycivici cagataycivici added the Type: Bug Issue contains a defect related to a specific component. label Mar 14, 2018
@cagataycivici cagataycivici added this to the 1.5.0 milestone Mar 14, 2018
@cagataycivici cagataycivici changed the title Dialog resize/re-render when data changes Improve dialog positioning with Dynamic content Mar 14, 2018
@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Type: Bug Issue contains a defect related to a specific component. labels Mar 14, 2018
@cagataycivici
Copy link
Member

cagataycivici commented Mar 14, 2018 •
edited
Loading

Applied same solution as we did for PrimeNG dialog recently. Added docs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@cagataycivici @YourJest