Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPicker is not updated if value property is changed #412

Closed
RushPVA opened this issue May 16, 2018 · 4 comments
Closed

ColorPicker is not updated if value property is changed #412

RushPVA opened this issue May 16, 2018 · 4 comments
Assignees
@mertsincan
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
1.6.0

Comments

@RushPVA
Copy link

RushPVA commented May 16, 2018 •
edited
Loading

primereact version: 1.5.2
ColorPicker.js shouldComponentUpdate always return false
because
componentWillReceiveProps is called before.
so oldValue and newValue always equals.

Because of it color is not rerendered
@mertsincan
Copy link
Member

Could you please attach a sample plunker for us to replicate? You can use https://plnkr.co/edit/C6qjkdLtbmy92Hogdnjb?p=preview

@RushPVA
Copy link
Author

RushPVA commented May 27, 2018

https://plnkr.co/edit/le4suJPGUNnKMOUJvVNE?p=preview
I would recommend you to check other components with similar test

@RushPVA
Copy link
Author

RushPVA commented May 27, 2018

sample shows that if state is changed it doesn't affect ColorPicker

@mertsincan
Copy link
Member

Thanks a lot for the Plunker, I'll check and get back to you.

@mertsincan mertsincan self-assigned this May 30, 2018
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label May 30, 2018
@mertsincan mertsincan added this to the 1.6.0 milestone May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@RushPVA @mertsincan