Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabView: Does not show which Tab is selected when using TabPanel with Styled component #4826

Closed
navnitkapadia opened this issue Aug 25, 2023 · 1 comment
Closed

TabView: Does not show which Tab is selected when using TabPanel with Styled component #4826

navnitkapadia opened this issue Aug 25, 2023 · 1 comment
Labels
Resolution: By Design The behavior in the issue is by design and the component exhibits the expected behavior

Comments

@navnitkapadia
Copy link

Describe the bug

When you wrap with styled component Tabview and TabPanel it will hide

Reproducer

https://codesandbox.io/s/primereact-demo-forked-q2rmgl?file=/src/App.js:1688-1701

PrimeReact version

9.6.2

React version

18.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome 116.0.5845.96

Steps to reproduce the behavior

Simply wrap the component with styled with styled-component lib.

Expected behavior

It should show tab and tab panels
@navnitkapadia navnitkapadia added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 25, 2023
@melloware melloware added Resolution: By Design The behavior in the issue is by design and the component exhibits the expected behavior and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 25, 2023
@melloware
Copy link
Member

melloware commented Aug 25, 2023 •
edited
Loading

Unfortunatley this is currently by design. TabPanel's are not components themselves and the TabView needs instances of TabPanels so your custom objects are being ignored.

See this post: #2052

@melloware melloware closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Resolution: By Design The behavior in the issue is by design and the component exhibits the expected behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@melloware @navnitkapadia