Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ID to menubar top level prevents focus #5930

Closed
nitrogenous opened this issue Feb 9, 2024 · 1 comment
Closed

Add ID to menubar top level prevents focus #5930

nitrogenous opened this issue Feb 9, 2024 · 1 comment
Assignees
@nitrogenous
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a defect related to a specific component.
Milestone
10.5.1

Comments

@nitrogenous
Copy link
Contributor

When we add an ID to menu item it's no longer supporting focus optins.

const menubarItems = [
{
label: 'File',
icon: 'fal fa-file',
id: 'test',
},
{
label: 'View',
icon: 'far fa-magnifying-glass',
},
];
@nitrogenous nitrogenous added Type: Bug Issue contains a defect related to a specific component. Core Team Issue or pull request has been *opened* by a member of Core Team labels Feb 9, 2024
@nitrogenous nitrogenous added this to the 10.5.1 milestone Feb 9, 2024
@nitrogenous nitrogenous self-assigned this Feb 9, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 9, 2024
@nitrogenous nitrogenous mentioned this issue Feb 9, 2024
Merged
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 9, 2024
@mertsincan
Copy link
Member

Fixed in #5933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nitrogenous nitrogenous

Labels
Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.5.1
Development

When branches are created from issues, their pull requests are automatically linked.

5930-add-id-to-menubar-top-level-prevents-focus nitrogenous/primereact
3 participants
@melloware @mertsincan @nitrogenous