Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to use dataKey as the key in Dropdown #727

Closed
jan0991 opened this issue Jan 8, 2019 · 1 comment
Closed

Ability to use dataKey as the key in Dropdown #727

jan0991 opened this issue Jan 8, 2019 · 1 comment
Assignees
@cagataycivici
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.0.0-rc.1

Comments

@jan0991
Copy link

jan0991 commented Jan 8, 2019

Is it possible to specify what <Dropdown> will use for item keys? Right now if I have two items with the same label it uses the same keys and I keep getting

Encountered two children with the same key, `Business Park`. Keys should be unique...
@cagataycivici cagataycivici changed the title Dropdown duplicate keys Ability to use dataKey as the key in Dropdown Jan 10, 2019
@cagataycivici cagataycivici self-assigned this Jan 10, 2019
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jan 10, 2019
@cagataycivici cagataycivici added this to the 3.0.0-rc.1 milestone Jan 10, 2019
@cagataycivici
Copy link
Member

cagataycivici commented Jan 10, 2019 •
edited
Loading

Added support to utilize the dataKey prop which resolves to a unique field in the option value. Still I think it is not very common to have two options with the same label in the dropdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.0.0-rc.1
Development

No branches or pull requests
2 participants
@cagataycivici @jan0991