Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

propTypes error using new iconsTemplate #780

Closed
keul opened this issue Feb 20, 2019 · 0 comments
Closed

propTypes error using new iconsTemplate #780

keul opened this issue Feb 20, 2019 · 0 comments
Assignees
@mertsincan
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
3.1.1

Comments

@keul
Copy link
Contributor

keul commented Feb 20, 2019

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

When I submitted #716 seems I used the wrong prop-types type for the new iconsTemplate:

https://github.com/bopen/primereact/blob/8fe4b158ca09fe740e9b490cf787a1323378fd28/src/components/sidebar/Sidebar.d.ts#L14

I'm sorry for that. Now using the new feature you'll get a warning:

checkPropTypes.js?6ec4:19 Warning: Failed prop type: Invalid prop `iconsTemplate` of type `function` supplied to `Sidebar`, expected a single ReactElement
@mertsincan mertsincan self-assigned this Feb 28, 2019
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Feb 28, 2019
@mertsincan mertsincan added this to the 3.1.1 milestone Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
3.1.1
Development

No branches or pull requests
2 participants
@keul @mertsincan