Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"propTypes" incorrectly named as "propsTypes" #784

Closed
partynikko opened this issue Feb 22, 2019 · 1 comment
Closed

"propTypes" incorrectly named as "propsTypes" #784

partynikko opened this issue Feb 22, 2019 · 1 comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
3.1.1

Comments

@partynikko
Copy link
Contributor

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior

43 components have wrongfully declared propTypes as propsTypes.
See search results within primereact here: https://github.com/primefaces/primereact/search?p=1&q=propstypes&unscoped_q=propstypes

Expected behavior
Expects propsTypes to be renamed to propTypes so it can work together with React.

  • PrimeReact version:
    3.1.0
@partynikko partynikko mentioned this issue Feb 22, 2019
Merged
@mertsincan
Copy link
Member

Good catch! Thanks a lot for the PR!

@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Feb 28, 2019
@mertsincan mertsincan added this to the 3.1.1 milestone Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
3.1.1
Development

No branches or pull requests
2 participants
@partynikko @mertsincan