Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar input sometimes shows Calendar Panel on click not always #857

Closed
vdamrongsri opened this issue Apr 23, 2019 · 1 comment
Closed

Comments

@vdamrongsri
Copy link
Contributor

vdamrongsri commented Apr 23, 2019

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
This bug is not so easy to reproduce, however, I did get it on a screen recording on the https://www.primefaces.org/primereact/#/calendar. Basically, sometimes when clicking on the Calendar input when the Calendar panel is hidden, the Calendar input focuses but does not show the Calendar panel.

After some debugging, I found that it's because the onClick function does not always get called when the input is clicked. I have found a fix for this bug.
Here: https://github.com/primefaces/primereact/pull/858

Expected behavior
When clicking on the Calendar input when the Calendar panel is hidden the Calendar panel should always show.

Minimal reproduction of the problem with instructions
As mentioned before it's difficult to reproduce.

  1. Go to https://www.primefaces.org/primereact/#/calendar
  2. Click on Calendar input and click away from Calendar input, repeat until the Calendar input only focuses and does not display the Calendar. (I found it easier to reproduce with the Time / 24h Calendar input)
  3. If functionality works fine after a number of times, try refreshing the page and trying step one again.
  • PrimeReact version:
    "primereact": "^3.1.2"

[* Browser: [all ]

@mertsincan
Copy link
Member

I think this issue is fixed for the next version(3.1.3). Please see;
#869

if this problem persists with v3.1.3, please re-open this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants