Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features: importPT fields are displayed in the source code #28

Closed
LemonAppleMo opened this issue Nov 16, 2023 · 3 comments
Closed

Features: importPT fields are displayed in the source code #28

LemonAppleMo opened this issue Nov 16, 2023 · 3 comments

Comments

@LemonAppleMo
Copy link

I don't think that field should be in the runtime config. 😂

https://primevue.org/nuxt/#importpt

image

@LemonAppleMo
Copy link
Author

https://github.com/primefaces/primevue-nuxt-module/blob/main/src/module.ts#L42-L47

const { importPT, ...restModuleOptions } = moduleOptions;

nuxt.options.runtimeConfig.public.primevue = {
  ...restModuleOptions,
  ...registered
};

I think it's better this way.

@mertsincan
Copy link
Member

Hi,

This is related to serializable definitions. Please see my comments;
#6 (comment)

Best Regards,

@LemonAppleMo
Copy link
Author

I'm so sorry. I've been so busy with the company for the last two months.

Thank you so much for answering my question. 😊😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants