Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.6.0 - ConfirmDialog not opening after closing #1746

Closed
Thane2376 opened this issue Nov 12, 2021 · 1 comment
Closed

2.6.0 - ConfirmDialog not opening after closing #1746

Thane2376 opened this issue Nov 12, 2021 · 1 comment
Assignees

Comments

@Thane2376
Copy link

All event are unregistering when user clicks on close button in dialog. As the result Its unable to re-open confirm dialog again.

Expected behavior: close should be processed as reject.

closeDialog($event) {
if(DomHandler.hasClass($event.target, 'p-dialog-header-close') || DomHandler.hasClass($event.target, 'p-dialog-header-close-icon')) {
ConfirmationEventBus.off('confirm');
ConfirmationEventBus.off('close');
this.visible = false;
}

@tugcekucukoglu tugcekucukoglu added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 15, 2021
@tugcekucukoglu tugcekucukoglu added this to the 2.6.1 milestone Nov 15, 2021
@tugcekucukoglu tugcekucukoglu self-assigned this Nov 15, 2021
@cagataycivici cagataycivici removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 17, 2021
@cagataycivici cagataycivici added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 17, 2021
@tugcekucukoglu tugcekucukoglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 24, 2021
@tugcekucukoglu tugcekucukoglu removed this from the 2.6.1 milestone Nov 24, 2021
@tugcekucukoglu
Copy link
Member

This issue is about mitt version. We decided to remove this dependency. Please check this issue. It's fixed for the next version.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants