Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar: Time only mode does not work #4952

Closed
Ancient-Dragon opened this issue Dec 11, 2023 · 5 comments
Closed

Calendar: Time only mode does not work #4952

Ancient-Dragon opened this issue Dec 11, 2023 · 5 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Ancient-Dragon
Copy link
Contributor

Describe the bug

When I try to use time only mode, the date is shown. I wouldn't expect the date to be shown as well.

Reproducer

https://primevue.org/calendar/#time

PrimeVue version

3.42.0

Vue version

3.x

Language

ALL

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

View the documentation page and use the time only calendar, select a time and see that the date is there.

Expected behavior

When I click on a time the date does not appear. This is regression from 3.38.1 which used to work as expected.

@Ancient-Dragon Ancient-Dragon added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 11, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 11, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.44.0 milestone Dec 11, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Dec 11, 2023
@Ancient-Dragon
Copy link
Contributor Author

This PR is the problem: #4901

@Ancient-Dragon
Copy link
Contributor Author

Ancient-Dragon commented Dec 11, 2023

Looks like the changes to formatDateTime are the problem in that PR, by reverting those changes I was able to get it working again with timeOnly mode

@Ancient-Dragon
Copy link
Contributor Author

@tugcekucukoglu let me know if you want me to push changes / make the PR.

@tugcekucukoglu
Copy link
Member

Sorry, I did not see your comments. You could always send PR, we'll gratefully review it.

@rstainsby
Copy link
Contributor

This PR is the problem: #4901

Apologies, this PR was never intended to be merged in it's current state, I only created it to help triage another issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants