Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: Escape key doesn't close the Slidebar #5016

Closed
real-supreme opened this issue Jan 1, 2024 · 0 comments · Fixed by #5018
Closed

Sidebar: Escape key doesn't close the Slidebar #5016

real-supreme opened this issue Jan 1, 2024 · 0 comments · Fixed by #5018
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@real-supreme
Copy link

Describe the bug

Slidebar doesn't close on click of escape key when click anywhere on the screen (except the close icon)

Reproducer

https://codesandbox.io/s/primevue-demo-forked-c3wvrp?file=/src/App.vue

PrimeVue version

3.31.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Nuxt

Browser(s)

No response

Steps to reproduce the behavior

  1. Click on the button to open the slidebar
  2. Tap anywhere in the screen (except the close icon)
  3. Then press esc key on your keyboard
  4. Slidebar doesn't close [ERROR]

This works if step 2 is omitted (if you don't click anywhere else, esc key does close the slidebar)

Expected behavior

The Slidebar should close on click of escape key on your keyboard, even if you click on any random element.

@real-supreme real-supreme added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 1, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 5, 2024
@tugcekucukoglu tugcekucukoglu added this to the 3.46.0 milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants