Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar: dismissable prop can't be changed dynamically #5563

Closed
XavierChevalier opened this issue Apr 10, 2024 · 0 comments · Fixed by #5568
Closed

Sidebar: dismissable prop can't be changed dynamically #5563

XavierChevalier opened this issue Apr 10, 2024 · 0 comments · Fixed by #5568
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.52.0

Comments

@XavierChevalier
Copy link

XavierChevalier commented Apr 10, 2024 •
edited
Loading

Describe the bug

After a Sidebar component is already mounted, changing the dismissable prop has no effect. The initial value is the one that affects until hiding and re-showing the sidebar.

Reproducer

https://stackblitz.com/edit/primevue-create-vue-issue-template-afblon?file=src%2FApp.vue

PrimeVue version

3.47.2

Vue version

3.x

Language

ALL

Build / Runtime

Nuxt

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Even after the sidebar is shown, changing the value of dismissable prop should change the dismissability of the component.

Similar fixed issue on OverlayPanel: #2540
@XavierChevalier XavierChevalier added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 10, 2024
@XavierChevalier XavierChevalier mentioned this issue Apr 11, 2024
Merged
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 19, 2024
@tugcekucukoglu tugcekucukoglu added this to the 3.52.0 milestone Apr 19, 2024
@tugcekucukoglu tugcekucukoglu changed the title Sidbar: dismissable prop can't be changed dynamically Sidebar: dismissable prop can't be changed dynamically Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.52.0
Development

Successfully merging a pull request may close this issue.

fix(sidebar): dismissable property should still be reactive after mount XavierChevalier/primevue
2 participants
@XavierChevalier @tugcekucukoglu