Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer: Footer Div/Slot added by default #6048

Closed
ShrinidhiRajeevKulal opened this issue Jul 11, 2024 · 0 comments
Closed

Drawer: Footer Div/Slot added by default #6048

ShrinidhiRajeevKulal opened this issue Jul 11, 2024 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ShrinidhiRajeevKulal
Copy link

Describe the bug

In PrimeVue version 4, the Drawer component automatically includes a footer div or footer slot by default. This behavior occurs even when the footer slot is not explicitly mentioned or needed. We would prefer the footer to only be added when explicitly defined.
screenshot

Reproducer

https://stackblitz.com/edit/primevue-4-vite-issue-template-18djpc?file=src%2FApp.vue

PrimeVue version

4.0.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

Chrome, Firefox

Steps to reproduce the behavior

  1. Use the Drawer component without specifying a footer slot.
  2. Inspect the rendered HTML of the Drawer component.
  3. Observe the presence of a footer div or slot.

Expected behavior

The Drawer component should not include a footer div or slot unless explicitly defined by the user.

@ShrinidhiRajeevKulal ShrinidhiRajeevKulal added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 11, 2024
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 31, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Jul 31, 2024
@tugcekucukoglu tugcekucukoglu added this to the 4.0.4 milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants