Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal dialog not blocking background #77

Closed
fairking opened this issue Oct 24, 2019 · 1 comment
Closed

Modal dialog not blocking background #77

fairking opened this issue Oct 24, 2019 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@fairking
Copy link

fairking commented Oct 24, 2019

I have the following modal:

<Dialog v-if="createRowVisible" :visible.sync="createRowVisible" 
        header="Add contact" :modal="true">
	<CreateContactForm @on-cancel="hideCreateDialog" @on-success="rowCreated" />
</Dialog>

When modal is opened the background is not blocked and I can still manupulate anything outside of the modal modal.

Also it would be nice if blocked backgroud gets dimmed. So users know it is blobked.
Thank you.

@cagataycivici cagataycivici self-assigned this Nov 1, 2019
@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Nov 1, 2019
@cagataycivici cagataycivici added this to the 1.0.0-beta.13 milestone Nov 1, 2019
@cagataycivici
Copy link
Member

It seems dimmed for me, at least on showcase, we'll apply the trapFocus we had on other Prime dialogs like NG has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants