Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modification Request] CTA Banner to support a background image #756

Open
jjwinskill opened this issue Sep 16, 2024 · 1 comment
Open

[Modification Request] CTA Banner to support a background image #756

jjwinskill opened this issue Sep 16, 2024 · 1 comment
Labels

Comments

@jjwinskill
Copy link

Summary

As part of the Newsroom project, we've added a one-off style override for our CTA Banner to support a background image (example at https://github.com/newsroom - scroll close to bottom to see it).

Screenshot

Image

We've had additional requests to use this pattern on other templates, so we'd like to standardize using a background image in the CTA Banner so it can be added as a field in our CMS.

Implementation Details

There is a possible conflict here with the useBackground property, as that could be confusing while also using a background image.

Urgency

This is being asked for as a standard for other templates, but we do have a workaround for now (though each use case accrues some minor tech debt).

@joshfarrant
Copy link
Contributor

Thanks for this @jjwinskill.

There's a somewhat related discussion ongoing in #752 too, so we can potentially tackle both of these issues together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

3 participants