Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionList Item - hovered item with subitems doesn't show focus ring #2254

Closed
jdrush89 opened this issue Sep 13, 2022 · 0 comments · Fixed by #2255
Closed

ActionList Item - hovered item with subitems doesn't show focus ring #2254

jdrush89 opened this issue Sep 13, 2022 · 0 comments · Fixed by #2255

Comments

@jdrush89
Copy link
Contributor

jdrush89 commented Sep 13, 2022

Describe the bug
If an element matches .ActionList-item.ActionList-item--hasSubItem > .ActionList-content is focused with the keyboard and hovered with the mouse then the focus ring around the content disappears. It looks like it is due to this rule which overrides the outline from the focus-visible class.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/github/github/tree/master/.devcontainer?_features=react_repos_code_view
  2. Tab into the file tree, then use the arrow keys to move focus to a non-active directory row like seeds
  3. Hover over the focused row
  4. See the focus ring disappear

Expected behavior
The focus ring should not disappear. The linked rule checks that nav is not active, it should probably also check that focus-visible is not present.

Desktop (please complete the following information):

  • OS: macOs
  • Browser chrome
  • Version 104.0.5112.101 (Official Build) (x86_64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant