Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider remove kbd from markdown bundle #919

Closed
simurai opened this issue Oct 1, 2019 · 1 comment
Closed

Consider remove kbd from markdown bundle #919

simurai opened this issue Oct 1, 2019 · 1 comment
Labels
major release type: question

Comments

@simurai
Copy link
Contributor

simurai commented Oct 1, 2019

In #904 we will add kbd styling to base. But we also keep kbd in the markdown bundle to not break usages where base is not included.

For a future major release, we could consider removing kbd support if only the markdown bundle is used. We would have to update mobile and embedded gists to also import base. See #904 (comment).
@simurai simurai mentioned this issue Oct 1, 2019
Merged
6 tasks
@shawnbot
Copy link
Contributor

shawnbot commented Oct 7, 2019

We've decided not to do this and instead @import "kbd.scss" in both our base and markdown bundles in #904. ✌️

@shawnbot shawnbot closed this as completed Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major release type: question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shawnbot @simurai