Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distinction in css colors #92

Open
la-magbanua opened this issue Nov 6, 2020 · 5 comments
Open

distinction in css colors #92

la-magbanua opened this issue Nov 6, 2020 · 5 comments
Labels
type: syntax Syntax highlighting

Comments

@la-magbanua
Copy link

First of all this theme has been my daily driver, it's too good! One thing I've noticed though is that the CSS property and value sometimes could be hard to differentiate. Would be nice and easier to scan with the eyes if the shade or tint would be adjusted. Appreciate the work, thank you!

snippet

@simurai
Copy link
Contributor

simurai commented Nov 6, 2020

This theme tries to stay close to the highlighting here on github.com.

I do see a difference when the language is set to .css:

main {
  flex: 1;
  position: relative;
}

But when using .scss, this theme matches:

main {
  flex: 1;
  position: relative;
}

Not sure how high priority this is but it would be nice to align it a bit more.

@la-magbanua
Copy link
Author

Would be cool if this got color distinction as well...

snippet

@macintacos
Copy link

I know that we're trying to keep as close to GitHub's dark theme, but maybe that needs to be improved as well (I'm not sure where to direct that bit of feedback, but may as well do it here). This CSS syntax highlighting is barely better than just plaintext:

image

Constrast with something like the Dracula theme, where separators, key/value pairs, strings, etc. at least have contrasting colors enough so that it's visually easier (for me of course) to parse:

image

Surely CSS could be handled better than it currently is?

@simurai
Copy link
Contributor

simurai commented Apr 22, 2021

This CSS syntax highlighting is barely better than just plaintext

Yeah, especially for scss:

.class.one-more-class:hover {
  color: red;
  background-color: #123456;
}

There is a discussion regarding the question if it's ok for this theme to improve highlighting even if it starts to deviate from github.com: #147

@arlorose
Copy link

Any movement on this decision?

I just discovered this theme today and love it, but CSS is unusable. Just adding my voice here, but will also likely branch the theme and alter it so CSS is usable for me. :-)

@simurai simurai added the type: syntax Syntax highlighting label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: syntax Syntax highlighting
Projects
None yet
Development

No branches or pull requests

4 participants