Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forms are not eager loaded #3084

Closed
jhawthorn opened this issue Sep 12, 2024 · 0 comments · Fixed by #3099
Closed

Forms are not eager loaded #3084

jhawthorn opened this issue Sep 12, 2024 · 0 comments · Fixed by #3099
Assignees
Labels

Comments

@jhawthorn
Copy link

We're seeing files inside lib/primer/forms/ being lazily-loaded in a production environment. This is undesirable because it moves what should be boot time costs to users, is less friendly to Copy-on-Write memory and YJIT, and other issues.

https://github.com/primer/view_components/blob/main/lib/primer/view_components/engine.rb#L12-L14

Though also it seems like lib/ should not be an autoload directory at all, as other files are explicitly required. Maybe lib/primer/forms/ should be in app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants