Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

Valid PR changing github config are rejected #126

Open
prince-chrismc opened this issue Apr 7, 2023 · 0 comments
Open

Valid PR changing github config are rejected #126

prince-chrismc opened this issue Apr 7, 2023 · 0 comments

Comments

@prince-chrismc
Copy link
Owner

16926 rejected for the files, or lack thereof, make this PR invalid

https://github.com/prince-chrismc/conan-center-index-pending-review/actions/runs/4635084174/jobs/8201840810#step:6:235


https://api.github.com/repos/conan-io/conan-center-index/pulls/16926/files

[
  {
    "sha": "b2733bea8c3a6b0a91b16f06a9e3627501640c1e",
    "filename": ".gitignore",
    "status": "modified",
    "additions": 1,
    "deletions": 0,
    "changes": 1,
    "blob_url": "https://github.com/conan-io/conan-center-index/blob/78324089bb218ee4bff6a49259f485ed1dc1014a/.gitignore",
    "raw_url": "https://github.com/conan-io/conan-center-index/raw/78324089bb218ee4bff6a49259f485ed1dc1014a/.gitignore",
    "contents_url": "https://api.github.com/repos/conan-io/conan-center-index/contents/.gitignore?ref=78324089bb218ee4bff6a49259f485ed1dc1014a",
    "patch": "@@ -1,5 +1,6 @@\n # Conan specific\n **/test_package/build/\n+**/test_package/build-*/\n **/test_package/test_output/\n conan.lock\n conanbuildinfo.txt"
  }
]

https://api.github.com/repos/conan-io/conan-center-index/pulls/16926

{
  "url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16926",
  "id": 1304761391,
  "node_id": "PR_kwDODDMJAM5NxRQv",
  "html_url": "https://github.com/conan-io/conan-center-index/pull/16926",
  "diff_url": "https://github.com/conan-io/conan-center-index/pull/16926.diff",
  "patch_url": "https://github.com/conan-io/conan-center-index/pull/16926.patch",
  "issue_url": "https://api.github.com/repos/conan-io/conan-center-index/issues/16926",
  "number": 16926,
  "state": "open",
  "locked": false,
  "title": "Ignore more test_package build dir patterns",
  "user": {
    "login": "gjasny",
    "id": 1165598,
    "node_id": "MDQ6VXNlcjExNjU1OTg=",
    "avatar_url": "https://avatars.githubusercontent.com/u/1165598?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/gjasny",
    "html_url": "https://github.com/gjasny",
    "followers_url": "https://api.github.com/users/gjasny/followers",
    "following_url": "https://api.github.com/users/gjasny/following{/other_user}",
    "gists_url": "https://api.github.com/users/gjasny/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/gjasny/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/gjasny/subscriptions",
    "organizations_url": "https://api.github.com/users/gjasny/orgs",
    "repos_url": "https://api.github.com/users/gjasny/repos",
    "events_url": "https://api.github.com/users/gjasny/events{/privacy}",
    "received_events_url": "https://api.github.com/users/gjasny/received_events",
    "type": "User",
    "site_admin": false
  },
  "body": "In the binutils recipe (PR #16920) with `basic_layout`, a `recipes/binutils/all/test_package/build-release/`\r\ndirectory appears.\r\n\r\n---\r\n\r\n- [x] I've read the [contributing guidelines](https://github.com/conan-io/conan-center-index/blob/master/CONTRIBUTING.md).\r\n- [x] I've used a [recent](https://github.com/conan-io/conan/releases/latest) Conan client version close to the [currently deployed](https://github.com/conan-io/conan-center-index/blob/master/.c3i/config_v1.yml#L6).\r\n- [x] I've tried at least one configuration locally with the [conan-center hook](https://github.com/conan-io/hooks.git) activated.\r\n",
  "created_at": "2023-04-06T13:29:39Z",
  "updated_at": "2023-04-07T03:48:25Z",
  "closed_at": null,
  "merged_at": null,
  "merge_commit_sha": "9ac70a7505de900c055786e2c645f2704890a36a",
  "assignee": null,
  "assignees": [

  ],
  "requested_reviewers": [

  ],
  "requested_teams": [

  ],
  "labels": [
    {
      "id": 2795529524,
      "node_id": "MDU6TGFiZWwyNzk1NTI5NTI0",
      "url": "https://api.github.com/repos/conan-io/conan-center-index/labels/GitHub%20config",
      "name": "GitHub config",
      "color": "0AF35C",
      "default": false,
      "description": ""
    }
  ],
  "milestone": null,
  "draft": false,
  "commits_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16926/commits",
  "review_comments_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16926/comments",
  "review_comment_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments{/number}",
  "comments_url": "https://api.github.com/repos/conan-io/conan-center-index/issues/16926/comments",
  "statuses_url": "https://api.github.com/repos/conan-io/conan-center-index/statuses/78324089bb218ee4bff6a49259f485ed1dc1014a",
  "head": {
    "label": "gjasny:extend-gitignore",
    "ref": "extend-gitignore",
    "sha": "78324089bb218ee4bff6a49259f485ed1dc1014a",
    "user": {
      "login": "gjasny",
      "id": 1165598,
      "node_id": "MDQ6VXNlcjExNjU1OTg=",
      "avatar_url": "https://avatars.githubusercontent.com/u/1165598?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/gjasny",
      "html_url": "https://github.com/gjasny",
      "followers_url": "https://api.github.com/users/gjasny/followers",
      "following_url": "https://api.github.com/users/gjasny/following{/other_user}",
      "gists_url": "https://api.github.com/users/gjasny/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/gjasny/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/gjasny/subscriptions",
      "organizations_url": "https://api.github.com/users/gjasny/orgs",
      "repos_url": "https://api.github.com/users/gjasny/repos",
      "events_url": "https://api.github.com/users/gjasny/events{/privacy}",
      "received_events_url": "https://api.github.com/users/gjasny/received_events",
      "type": "User",
      "site_admin": false
    },
    "repo": {
      "id": 429185352,
      "node_id": "R_kgDOGZTZSA",
      "name": "conan-center-index",
      "full_name": "gjasny/conan-center-index",
      "private": false,
      "owner": {
        "login": "gjasny",
        "id": 1165598,
        "node_id": "MDQ6VXNlcjExNjU1OTg=",
        "avatar_url": "https://avatars.githubusercontent.com/u/1165598?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/gjasny",
        "html_url": "https://github.com/gjasny",
        "followers_url": "https://api.github.com/users/gjasny/followers",
        "following_url": "https://api.github.com/users/gjasny/following{/other_user}",
        "gists_url": "https://api.github.com/users/gjasny/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/gjasny/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/gjasny/subscriptions",
        "organizations_url": "https://api.github.com/users/gjasny/orgs",
        "repos_url": "https://api.github.com/users/gjasny/repos",
        "events_url": "https://api.github.com/users/gjasny/events{/privacy}",
        "received_events_url": "https://api.github.com/users/gjasny/received_events",
        "type": "User",
        "site_admin": false
      },
      "html_url": "https://github.com/gjasny/conan-center-index",
      "description": "Recipes for the ConanCenter repository",
      "fork": true,
      "url": "https://api.github.com/repos/gjasny/conan-center-index",
      "forks_url": "https://api.github.com/repos/gjasny/conan-center-index/forks",
      "keys_url": "https://api.github.com/repos/gjasny/conan-center-index/keys{/key_id}",
      "collaborators_url": "https://api.github.com/repos/gjasny/conan-center-index/collaborators{/collaborator}",
      "teams_url": "https://api.github.com/repos/gjasny/conan-center-index/teams",
      "hooks_url": "https://api.github.com/repos/gjasny/conan-center-index/hooks",
      "issue_events_url": "https://api.github.com/repos/gjasny/conan-center-index/issues/events{/number}",
      "events_url": "https://api.github.com/repos/gjasny/conan-center-index/events",
      "assignees_url": "https://api.github.com/repos/gjasny/conan-center-index/assignees{/user}",
      "branches_url": "https://api.github.com/repos/gjasny/conan-center-index/branches{/branch}",
      "tags_url": "https://api.github.com/repos/gjasny/conan-center-index/tags",
      "blobs_url": "https://api.github.com/repos/gjasny/conan-center-index/git/blobs{/sha}",
      "git_tags_url": "https://api.github.com/repos/gjasny/conan-center-index/git/tags{/sha}",
      "git_refs_url": "https://api.github.com/repos/gjasny/conan-center-index/git/refs{/sha}",
      "trees_url": "https://api.github.com/repos/gjasny/conan-center-index/git/trees{/sha}",
      "statuses_url": "https://api.github.com/repos/gjasny/conan-center-index/statuses/{sha}",
      "languages_url": "https://api.github.com/repos/gjasny/conan-center-index/languages",
      "stargazers_url": "https://api.github.com/repos/gjasny/conan-center-index/stargazers",
      "contributors_url": "https://api.github.com/repos/gjasny/conan-center-index/contributors",
      "subscribers_url": "https://api.github.com/repos/gjasny/conan-center-index/subscribers",
      "subscription_url": "https://api.github.com/repos/gjasny/conan-center-index/subscription",
      "commits_url": "https://api.github.com/repos/gjasny/conan-center-index/commits{/sha}",
      "git_commits_url": "https://api.github.com/repos/gjasny/conan-center-index/git/commits{/sha}",
      "comments_url": "https://api.github.com/repos/gjasny/conan-center-index/comments{/number}",
      "issue_comment_url": "https://api.github.com/repos/gjasny/conan-center-index/issues/comments{/number}",
      "contents_url": "https://api.github.com/repos/gjasny/conan-center-index/contents/{+path}",
      "compare_url": "https://api.github.com/repos/gjasny/conan-center-index/compare/{base}...{head}",
      "merges_url": "https://api.github.com/repos/gjasny/conan-center-index/merges",
      "archive_url": "https://api.github.com/repos/gjasny/conan-center-index/{archive_format}{/ref}",
      "downloads_url": "https://api.github.com/repos/gjasny/conan-center-index/downloads",
      "issues_url": "https://api.github.com/repos/gjasny/conan-center-index/issues{/number}",
      "pulls_url": "https://api.github.com/repos/gjasny/conan-center-index/pulls{/number}",
      "milestones_url": "https://api.github.com/repos/gjasny/conan-center-index/milestones{/number}",
      "notifications_url": "https://api.github.com/repos/gjasny/conan-center-index/notifications{?since,all,participating}",
      "labels_url": "https://api.github.com/repos/gjasny/conan-center-index/labels{/name}",
      "releases_url": "https://api.github.com/repos/gjasny/conan-center-index/releases{/id}",
      "deployments_url": "https://api.github.com/repos/gjasny/conan-center-index/deployments",
      "created_at": "2021-11-17T20:06:52Z",
      "updated_at": "2023-01-03T15:24:44Z",
      "pushed_at": "2023-04-06T19:01:26Z",
      "git_url": "git://github.com/gjasny/conan-center-index.git",
      "ssh_url": "[email protected]:gjasny/conan-center-index.git",
      "clone_url": "https://github.com/gjasny/conan-center-index.git",
      "svn_url": "https://github.com/gjasny/conan-center-index",
      "homepage": "https://conan.io/center",
      "size": 45537,
      "stargazers_count": 0,
      "watchers_count": 0,
      "language": "Python",
      "has_issues": false,
      "has_projects": true,
      "has_downloads": true,
      "has_wiki": true,
      "has_pages": false,
      "has_discussions": false,
      "forks_count": 0,
      "mirror_url": null,
      "archived": false,
      "disabled": false,
      "open_issues_count": 0,
      "license": {
        "key": "mit",
        "name": "MIT License",
        "spdx_id": "MIT",
        "url": "https://api.github.com/licenses/mit",
        "node_id": "MDc6TGljZW5zZTEz"
      },
      "allow_forking": true,
      "is_template": false,
      "web_commit_signoff_required": false,
      "topics": [

      ],
      "visibility": "public",
      "forks": 0,
      "open_issues": 0,
      "watchers": 0,
      "default_branch": "master"
    }
  },
  "base": {
    "label": "conan-io:master",
    "ref": "master",
    "sha": "b6207edbf977620839137e5365558cfe6663e16c",
    "user": {
      "login": "conan-io",
      "id": 15212165,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjE1MjEyMTY1",
      "avatar_url": "https://avatars.githubusercontent.com/u/15212165?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/conan-io",
      "html_url": "https://github.com/conan-io",
      "followers_url": "https://api.github.com/users/conan-io/followers",
      "following_url": "https://api.github.com/users/conan-io/following{/other_user}",
      "gists_url": "https://api.github.com/users/conan-io/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/conan-io/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/conan-io/subscriptions",
      "organizations_url": "https://api.github.com/users/conan-io/orgs",
      "repos_url": "https://api.github.com/users/conan-io/repos",
      "events_url": "https://api.github.com/users/conan-io/events{/privacy}",
      "received_events_url": "https://api.github.com/users/conan-io/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "repo": {
      "id": 204671232,
      "node_id": "MDEwOlJlcG9zaXRvcnkyMDQ2NzEyMzI=",
      "name": "conan-center-index",
      "full_name": "conan-io/conan-center-index",
      "private": false,
      "owner": {
        "login": "conan-io",
        "id": 15212165,
        "node_id": "MDEyOk9yZ2FuaXphdGlvbjE1MjEyMTY1",
        "avatar_url": "https://avatars.githubusercontent.com/u/15212165?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/conan-io",
        "html_url": "https://github.com/conan-io",
        "followers_url": "https://api.github.com/users/conan-io/followers",
        "following_url": "https://api.github.com/users/conan-io/following{/other_user}",
        "gists_url": "https://api.github.com/users/conan-io/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/conan-io/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/conan-io/subscriptions",
        "organizations_url": "https://api.github.com/users/conan-io/orgs",
        "repos_url": "https://api.github.com/users/conan-io/repos",
        "events_url": "https://api.github.com/users/conan-io/events{/privacy}",
        "received_events_url": "https://api.github.com/users/conan-io/received_events",
        "type": "Organization",
        "site_admin": false
      },
      "html_url": "https://github.com/conan-io/conan-center-index",
      "description": "Recipes for the ConanCenter repository",
      "fork": false,
      "url": "https://api.github.com/repos/conan-io/conan-center-index",
      "forks_url": "https://api.github.com/repos/conan-io/conan-center-index/forks",
      "keys_url": "https://api.github.com/repos/conan-io/conan-center-index/keys{/key_id}",
      "collaborators_url": "https://api.github.com/repos/conan-io/conan-center-index/collaborators{/collaborator}",
      "teams_url": "https://api.github.com/repos/conan-io/conan-center-index/teams",
      "hooks_url": "https://api.github.com/repos/conan-io/conan-center-index/hooks",
      "issue_events_url": "https://api.github.com/repos/conan-io/conan-center-index/issues/events{/number}",
      "events_url": "https://api.github.com/repos/conan-io/conan-center-index/events",
      "assignees_url": "https://api.github.com/repos/conan-io/conan-center-index/assignees{/user}",
      "branches_url": "https://api.github.com/repos/conan-io/conan-center-index/branches{/branch}",
      "tags_url": "https://api.github.com/repos/conan-io/conan-center-index/tags",
      "blobs_url": "https://api.github.com/repos/conan-io/conan-center-index/git/blobs{/sha}",
      "git_tags_url": "https://api.github.com/repos/conan-io/conan-center-index/git/tags{/sha}",
      "git_refs_url": "https://api.github.com/repos/conan-io/conan-center-index/git/refs{/sha}",
      "trees_url": "https://api.github.com/repos/conan-io/conan-center-index/git/trees{/sha}",
      "statuses_url": "https://api.github.com/repos/conan-io/conan-center-index/statuses/{sha}",
      "languages_url": "https://api.github.com/repos/conan-io/conan-center-index/languages",
      "stargazers_url": "https://api.github.com/repos/conan-io/conan-center-index/stargazers",
      "contributors_url": "https://api.github.com/repos/conan-io/conan-center-index/contributors",
      "subscribers_url": "https://api.github.com/repos/conan-io/conan-center-index/subscribers",
      "subscription_url": "https://api.github.com/repos/conan-io/conan-center-index/subscription",
      "commits_url": "https://api.github.com/repos/conan-io/conan-center-index/commits{/sha}",
      "git_commits_url": "https://api.github.com/repos/conan-io/conan-center-index/git/commits{/sha}",
      "comments_url": "https://api.github.com/repos/conan-io/conan-center-index/comments{/number}",
      "issue_comment_url": "https://api.github.com/repos/conan-io/conan-center-index/issues/comments{/number}",
      "contents_url": "https://api.github.com/repos/conan-io/conan-center-index/contents/{+path}",
      "compare_url": "https://api.github.com/repos/conan-io/conan-center-index/compare/{base}...{head}",
      "merges_url": "https://api.github.com/repos/conan-io/conan-center-index/merges",
      "archive_url": "https://api.github.com/repos/conan-io/conan-center-index/{archive_format}{/ref}",
      "downloads_url": "https://api.github.com/repos/conan-io/conan-center-index/downloads",
      "issues_url": "https://api.github.com/repos/conan-io/conan-center-index/issues{/number}",
      "pulls_url": "https://api.github.com/repos/conan-io/conan-center-index/pulls{/number}",
      "milestones_url": "https://api.github.com/repos/conan-io/conan-center-index/milestones{/number}",
      "notifications_url": "https://api.github.com/repos/conan-io/conan-center-index/notifications{?since,all,participating}",
      "labels_url": "https://api.github.com/repos/conan-io/conan-center-index/labels{/name}",
      "releases_url": "https://api.github.com/repos/conan-io/conan-center-index/releases{/id}",
      "deployments_url": "https://api.github.com/repos/conan-io/conan-center-index/deployments",
      "created_at": "2019-08-27T09:43:58Z",
      "updated_at": "2023-04-04T02:41:04Z",
      "pushed_at": "2023-04-07T03:51:05Z",
      "git_url": "git://github.com/conan-io/conan-center-index.git",
      "ssh_url": "[email protected]:conan-io/conan-center-index.git",
      "clone_url": "https://github.com/conan-io/conan-center-index.git",
      "svn_url": "https://github.com/conan-io/conan-center-index",
      "homepage": "https://conan.io/center",
      "size": 45681,
      "stargazers_count": 722,
      "watchers_count": 722,
      "language": "Python",
      "has_issues": true,
      "has_projects": true,
      "has_downloads": true,
      "has_wiki": true,
      "has_pages": false,
      "has_discussions": true,
      "forks_count": 1271,
      "mirror_url": null,
      "archived": false,
      "disabled": false,
      "open_issues_count": 1557,
      "license": {
        "key": "mit",
        "name": "MIT License",
        "spdx_id": "MIT",
        "url": "https://api.github.com/licenses/mit",
        "node_id": "MDc6TGljZW5zZTEz"
      },
      "allow_forking": true,
      "is_template": false,
      "web_commit_signoff_required": false,
      "topics": [
        "conan",
        "conan-center",
        "conan-index",
        "conan-packages",
        "conan-recipe",
        "cpp",
        "cpp-library",
        "dependencies",
        "hacktoberfest",
        "package-management",
        "package-manager"
      ],
      "visibility": "public",
      "forks": 1271,
      "open_issues": 1557,
      "watchers": 722,
      "default_branch": "master"
    }
  },
  "_links": {
    "self": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16926"
    },
    "html": {
      "href": "https://github.com/conan-io/conan-center-index/pull/16926"
    },
    "issue": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/issues/16926"
    },
    "comments": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/issues/16926/comments"
    },
    "review_comments": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16926/comments"
    },
    "review_comment": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/comments{/number}"
    },
    "commits": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/pulls/16926/commits"
    },
    "statuses": {
      "href": "https://api.github.com/repos/conan-io/conan-center-index/statuses/78324089bb218ee4bff6a49259f485ed1dc1014a"
    }
  },
  "author_association": "CONTRIBUTOR",
  "auto_merge": null,
  "active_lock_reason": null,
  "merged": false,
  "mergeable": true,
  "rebaseable": true,
  "mergeable_state": "unstable",
  "merged_by": null,
  "comments": 1,
  "review_comments": 0,
  "maintainer_can_modify": true,
  "commits": 1,
  "additions": 1,
  "deletions": 0,
  "changed_files": 1
}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant