Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wolfy linux to supported OS #18329

Closed
mts-dyt opened this issue Mar 15, 2023 · 4 comments
Closed

Add wolfy linux to supported OS #18329

mts-dyt opened this issue Mar 15, 2023 · 4 comments
Labels
domain/client Issue in the "Client" domain: Prisma Client, Prisma Studio etc. kind/feature A request for a new feature. topic: engine topic: linux topic: os detection topic: OS/distro-resolution
Milestone

Comments

@mts-dyt
Copy link

mts-dyt commented Mar 15, 2023

Problem

We are using Node secure docker image from chainguard: cgr.dev/chainguard/node

The following message is displayed when using prisma:

prisma:warn Prisma doesn't know which engines to download for the Linux distro "wolfi". Falling back to Prisma engines built "debian".
Please report your experience by creating an issue at https://github.com/prisma/prisma/issues so we can add your distro to the list of known supported distros.

Suggested solution

Add chainguard secured OS as supported images

@mts-dyt mts-dyt changed the title Add wolf linux to supported OS Add wolfy linux to supported OS Mar 15, 2023
@janpio janpio added kind/feature A request for a new feature. domain/client Issue in the "Client" domain: Prisma Client, Prisma Studio etc. topic: linux labels Mar 15, 2023
@jbergstroem
Copy link

jbergstroem commented May 3, 2023

@dlorenc just pulling you in for awareness.

Its worth mentioning that the fallback choice works fine (at least for me).

Relevant os detection seems to be here:
https://github.com/prisma/prisma/blob/0064ee3b4f033b63704028a474624a8a3191855c/packages/get-platform/src/getPlatform.ts#L128C1-L137

@dlorenc
Copy link

dlorenc commented May 3, 2023

Thanks for tagging me, let me know if I can help at all.

@jbergstroem
Copy link

Thanks for tagging me, let me know if I can help at all.

Do you think it would make sense to use debian as targetDistro seeing how users then get a binary that works well with glibc and openssl? As I understand it, the client looks at the running environment and downloads a suitable engine from https://github.com/prisma/prisma-engines

@Jolg42
Copy link
Contributor

Jolg42 commented Mar 6, 2024

I'll close this, as the fallback/default engine should work as expected, so only a report would be needed if there is an issue, let us know if that's the case.

Note that we changed the message, to make it informational only in #23243
The updated message will be part of the next release 5.11.0, next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain/client Issue in the "Client" domain: Prisma Client, Prisma Studio etc. kind/feature A request for a new feature. topic: engine topic: linux topic: os detection topic: OS/distro-resolution
Projects
None yet
Development

No branches or pull requests

5 participants