You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe I broke the selector compression in this PR #290 via this commit eddbe95
I tried to split the selector to fixed process into two stages:
Just update the ConstraintSystem (replace selectors in gates, lookups etc with selector expressions built from fixed columns)
Transform assigned selectors to assigned fixed columns to be used for the selector expressions
For uncompressed selectors this works.
For compressed selectors this doesn't work, because step 1 requires the selector assignments to figure out how to build the selector expressions. Without the selector assignments the generated output is invalid.
There are a few reasons why this wasn't found in tests
There was another bug. The merging of original fixed columns assignments and fixed-from-selector columns was wrong, leading to the fixed-from-selector columns to be in an unused offset. This was missing
I can think of two possible solutions:
a. Revert the split of selector to fixed process to a single stage
b. Review the implementation of compile_selectors::process(...) and see if we can make it work without access to the selector assignments in the sage of updating the ConstraintSystem.
The text was updated successfully, but these errors were encountered:
I believe I broke the selector compression in this PR #290 via this commit eddbe95
I tried to split the selector to fixed process into two stages:
For uncompressed selectors this works.
For compressed selectors this doesn't work, because step 1 requires the selector assignments to figure out how to build the selector expressions. Without the selector assignments the generated output is invalid.
There are a few reasons why this wasn't found in tests
halo2/halo2_frontend/src/circuit.rs
Line 116 in 0469a7b
compile_circuit
#320I can think of two possible solutions:
a. Revert the split of selector to fixed process to a single stage
b. Review the implementation of
compile_selectors::process(...)
and see if we can make it work without access to the selector assignments in the sage of updating theConstraintSystem
.The text was updated successfully, but these errors were encountered: