Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generic-array v1.0 #61

Open
sinui0 opened this issue Sep 13, 2023 · 4 comments
Open

Use generic-array v1.0 #61

sinui0 opened this issue Sep 13, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@sinui0
Copy link
Collaborator

sinui0 commented Sep 13, 2023

fizyk20/generic-array#138 has been merged. Once RustCrypto crates adopt it, eg cipher, we should take advantage of this to get rid of transmutes in our Block impl introduced in #59
@sinui0 sinui0 added the good first issue Good for newcomers label Sep 13, 2023
@novacrazy
Copy link

It looks like the RustCrypto people are moving to hybrid-array instead of generic-array 1.0, so you may want to petition them to add these methods instead, if they haven't already.

@sinui0
Copy link
Collaborator Author

sinui0 commented Sep 13, 2023

It looks like the RustCrypto people are moving to hybrid-array instead of generic-array 1.0, so you may want to petition them to add these methods instead, if they haven't already.

Thanks for the heads up. It does seem their intention is to go straight to hybrid-array, I was assuming they would bump to generic-array 1.0 first.

@sinui0
Copy link
Collaborator Author

sinui0 commented Sep 13, 2023

RustCrypto/utils#951

@mahmudsudo
Copy link

hi can i take on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@novacrazy @sinui0 @mahmudsudo