Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve relative path extends in parent directory #77

Merged

Conversation

nwalters512
Copy link
Sponsor Contributor

Closes #76.

Using path.resolve to obtain an absolute path ensures that we search all the way up, instead of stopping at directoryPath.

@privatenumber privatenumber changed the title Fix resolution of extended configs with using relative path fix: resolve relative path extends in parent directory May 9, 2024
@privatenumber privatenumber merged commit 0a3270e into privatenumber:master May 9, 2024
2 of 3 checks passed
@nwalters512 nwalters512 deleted the fix-relative-path-resolution branch May 9, 2024 15:44
@privatenumber
Copy link
Owner

Appreciate your contributions as always @nwalters512 !

I invited you to my private development org if you're interested. Would love to collaborate more!

@privatenumber
Copy link
Owner

🎉 This PR is included in version 4.7.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nwalters512
Copy link
Sponsor Contributor Author

Thanks @privatenumber! I accepted the invitation.

@mrazauskas
Copy link

Seems like this change broke something with resolution of paths.

My project is using get-tsconfig via eslint-import-resolver-typescript. Recent lock file update failed because of resolution errors (the failure is gone, if get-tsconfig is not upgraded): https://github.com/tstyche/tstyche/actions/runs/9055459985/job/24876636622

paths are defined here (seems that the latest version of get-tsconfig fails to resolve this case):

https://github.com/tstyche/tstyche/blob/e3d6dd816849818aeac8ad9a9bbf373c8407932b/source/tsconfig.json#L6-L8

@privatenumber
Copy link
Owner

Would you mind filing a bug report, or a PR with a fix & test?

@mrazauskas
Copy link

Sorry, I can’t find time for that any soon. Just wanted to draw your attention.

@privatenumber
Copy link
Owner

Thanks, but until the bug is proven to be in get-tsconfig, I'm not able to invest time debugging (often times it turns out it's unrelated and I'm end up just debugging stuff for other people).

I'm going to lock this thread because it's not the appropriate place to discuss this.

Repository owner locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot resolve extended configs in a Yarn workspace
3 participants