fix: support configDir for other compilerOptions fields
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I didn't open an issue, it was faster to make a fix than a repro example :) |
|
No problem, thanks for the PR! Can you add a test or update the existing one for configDir to include these properties? |
Added test cases. Also, I fixed a bug when "declarationDir" was missing in generated "excludes", now that matches behaviour of TS :) |
privatenumber
changed the title
configDir for other compilerOptions fields
|
Ah nice catch! Thanks for the PR 🙌 |
|
🎉 This PR is included in version 4.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the "${configDir}" variable interpolation for all the fields in "compilerOptions" object as listed in the original issue