Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues and feature requests for Loom integration #190

Open
5 tasks
fsaad opened this issue Jan 9, 2017 · 3 comments
Open
5 tasks

Issues and feature requests for Loom integration #190

fsaad opened this issue Jan 9, 2017 · 3 comments

Comments

@fsaad
Copy link
Collaborator

fsaad commented Jan 9, 2017

  • Enable diagnostics and checkpointing.
    • Kernel counts
    • History of column partition and state CRP.
    • History of logscore.
  • Enable timed analysis (not sure whether this is possible by using the Loom API, probably need to interrupt the process, but that leave the metadata in an unusable state).
@fritzo
Copy link

fritzo commented Jul 5, 2017

Do you plan on integrating the loom.query.QeryServer interface?

@fsaad
Copy link
Collaborator Author

fsaad commented Jul 5, 2017

@fritzo Thanks for the question. In the current setup, cgpm invokes Loom only to obtain posterior CrossCat model structures (row and column partitions). Querying the model happens by extracting the model structures and creating a cgpm.crosscat.State object (each "state" roughly represents 1 loom "sample" or chain), and then using the infrastructure in cgpm for sampling and density assessment.

Since cgpm is largely unoptimized python, we definitely would plan on integrating loom.query.QueryServer to bypass the performance bottlenecks of cgpm.crosscat when querying larger datasets. I still have not considered whether it makes more sense to integrate the Loom query server into cgpm, which is mostly intended for flexible querying of shallow networks of both composite crosscat and non-crosscat models, or to bypass cgpm and integrate it by implementing the bayeslite.metamodel interface directly (which would result in more efficient querying, at the expense of reduced modeling and querying flexibility).

These decisions might be on our roadmap, and I will certainly reach out for your feedback if we have any questions or design issues with using/integrating Loom.

@fsaad
Copy link
Collaborator Author

fsaad commented Aug 10, 2017

Hi @fritzo, following up on this thread, an intern at the probcomp group wrote a metamodel in bayeslite which bypasses cgpm and uses Loom directly. The LoomMetamodel class is living here:

https://github.com/probcomp/bayeslite/blob/20170707-truell20-loom-integration/src/metamodels/loom_metamodel.py

We still haven't merged the branch since it needs some work and clean up on our side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants