Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor T_relation, T_clean_relation, and T_noisy_relation #205

Open
ThomasColthurst opened this issue Sep 23, 2024 · 0 comments
Open

Refactor T_relation, T_clean_relation, and T_noisy_relation #205

ThomasColthurst opened this issue Sep 23, 2024 · 0 comments

Comments

@ThomasColthurst
Copy link

Right now our code has a large number of std::visit calls just to get the domains or is_observed bit of a T_clean_relation or T_noisy_relation.

These could be eliminated if we switched T_relation from being a std::variant into being a base class that would contain the domains and is_observed and have T_clean_relation and T_noisy_relation inherit from it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant