onlyLabels not working

[takose]

Hi 👋

I tried to introduce stale bot to comment stale issues which has specific label, but stale bot has marked all issues. Can you take a look and let me know if something is not configured correctly?

Here is test repository.
https://github.com/takose/stalebot-test

stale.yml

# Configuration for probot-stale - https://github.com/probot/stale

# Number of days of inactivity before an Issue or Pull Request becomes stale
daysUntilStale: 1

# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable
exemptLabels: []

# Only issues or pull requests with all of these labels are check if stale. Defaults to `[]` (disabled)
onlyLabels:
  - TestLavbel

# Number of days of inactivity before an Issue or Pull Request with the stale label is closed.
# Set to false to disable. If disabled, issues still need to be closed manually, but will remain marked as stale.
daysUntilClose: false

# Label to use when marking as stale
staleLabel: wontfix

# Comment to post when marking as stale. Set to `false` to disable
markComment: >
  Please check progress.

Thanks.

[issue-label-bot]

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.73. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[Gustry]

Same for me. Stale bot just marked all issues of my repository with stale 5 minutes, while I got only 2 issues with the label candidate for closing.

Link to my stale.yml: https://github.com/3liz/QuickOSM/blob/master/.github/stale.yml#L12

# Only issues or pull requests with all of these labels are check if stale. Defaults to `[]` (disabled)
onlyLabels:
  - "candidate for closing"

Unfortunately, if no solution is found, I will have to disable stalebot because I don't want it to close all my issues.

GitHub

3liz/QuickOSM

QGIS plugin to fetch OSM data with the Overpass API - 3liz/QuickOSM

[kesselb]

Looks like labels are always wrapped in quotes. Mind to try candidate for closing without quotes? The yaml validator does not complain about missing quotes.

stale/lib/stale.js

Lines 73 to 74 in e3c53eb

	const queryParts = labels.map(label => `-label:"${label}"`)
	queryParts.concat(onlyLabels.map(label => `label:"${label}"`))

[Gustry]

No, it is still not working without quotes, look at this issue: 3liz/QuickOSM#167 (comment) It's tagged stale a few minutes ago without the label candidate for closing.

I made the following change to stalebot 3liz/QuickOSM@32762e9

Thanks

[skjnldsv]

Yep, probot is using js-yaml.
https://nodeca.github.io/js-yaml/

And quote or no quote does not make a difference in the parsing at all.
https://github.com/probot/probot-config/blob/master/lib/index.js#L24

Any help? @probot @tcbyrd ?

YAML parser for JavaScript - JS-YAML

Live example of YAML JavaScript parser right in your browser. Type your YAML code and see result.

GitHub

probot/probot-config

A Probot extension to easily share configs between repositories. - probot/probot-config

[takose]

I sent PR to fix this 😜
#213

[antelle]

Hi! Just came across the same issue, the bot closed several issues by mistake, which caused some confusion. I see that the pull request is very straightforward, can this please be merged 🙏? Not good to have it in production. Very sorry for the bump, but looks like it's somewhat forgotten, while the fix is already here.

[skjnldsv]

@antelle you better run your own stale bot, there is not much activity here :(
Fork it and merge the pending pr #213

I'm running it via docke-compose

version: '2'
services:
  stalebot:
    image: skjnldsv/stale:latest 
    restart: always
    ports:
      - 3000:3000
    environment:
      - APP_ID=12345
      - WEBHOOK_SECRET=123456789123456789123456789
      # - LOG_LEVEL=debug
      - PRIVATE_KEY_PATH=/app/private-key.pem
    volumes:
      - ./private-key.pem:/app/private-key.pem:ro

[antelle]

@skjnldsv I do see some activity, for example some PR's were merged a week ago: https://github.com/probot/stale/pulls?q=is%3Apr+is%3Aclosed

GitHub

probot/stale

A GitHub App built with Probot that closes abandoned Issues and Pull Requests after a period of inactivity. - probot/stale

[skjnldsv]

Yep, simple prs, like ci, dependencies or default config messages. :/

[Gustry]

FYI, there is now a builtin feature in Github for stale issues. It's called Action.
https://github.com/actions/stale

GitHub

actions/stale

Marks issues and pull requests that have not had recent interaction - actions/stale

[skjnldsv]

Thanks @Gustry !!

[antelle]

@Gustry thanks a lot! So, it's time to switch to it now.

[takose]

FYI, there is now a builtin feature in Github for stale issues. It's called Action.

It doesn't seem to have onlyLabels option.. 👀

I forked and tried to add onlyLabels option.(However it doesn't work as expected..)
https://github.com/takose/stale-1

GitHub

takose/stale-1

Marks issues and pull requests that have not had recent interaction - takose/stale-1