Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a 'Done. Downloading your gif!🌸' paragraph after a while #6084

Closed
1 of 17 tasks
agrshch opened this issue Mar 22, 2023 · 6 comments · Fixed by #6086
Closed
1 of 17 tasks

Deleting a 'Done. Downloading your gif!🌸' paragraph after a while #6084

agrshch opened this issue Mar 22, 2023 · 6 comments · Fixed by #6086

Comments

@agrshch
Copy link
Contributor

agrshch commented Mar 22, 2023

Increasing Access

Unsure

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build Process
  • Unit Testing
  • Internalization
  • Friendly Errors
  • Other (specify if possible)

Feature enhancement details

Hi,
this is a really minor improvement. Currently, when a user successfully generated a GIF with saveGif function, p5 shows a message Done. Downloading your gif!🌸, which stays on the screen forever. It would be nice to remove it after some amount of time.

p.html('Done. Downloading your gif!🌸');
setTimeout(()=> p.remove(),5000);

Thanks!

@anpanring
Copy link
Contributor

Is it okay if I work on this issue?

@agrshch
Copy link
Contributor Author

agrshch commented Mar 22, 2023

@anpanring if you don't mind, I would like to do it by myself. This would be my first contribution and this issue seems to be not too critical or too scary to work with.

@anpanring
Copy link
Contributor

@agrshch Of course, I understand!

@Cvr421
Copy link

Cvr421 commented Mar 24, 2023

Can i work on these issue

@agrshch
Copy link
Contributor Author

agrshch commented Mar 24, 2023

@Cvr421 I am working

@ffd8
Copy link
Contributor

ffd8 commented Mar 25, 2023

@agrshch thanks for pointing this out and working on it! Just came here to chime in and say 'what an amaaazing feature this saveGif() is!.... but that notification never goes away'.

It would also be helpful if there was either a silent:true option (so nothing is displayed on demand), and/or the ability to have the current notifications passed via callback with those values – so one could display the updates within a p5 sketch, rather than overlaying html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants